doc: update Http2Server.close & Http2SecureServer.close#63298
Merged
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
doc
lpinca
approved these changes
May 14, 2026
pimterry
approved these changes
May 15, 2026
Ethan-Arrowood
approved these changes
May 15, 2026
UlisesGascon
approved these changes
May 16, 2026
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com>
samuel871211
commented
May 16, 2026
Contributor
Author
|
Just a reminder, this PR has been idle for over a month. Could a member please assist in merging it? |
pimterry
approved these changes
Jun 29, 2026
pimterry
added
the
commit-queue
Member
|
Thanks for the nudge here @samuel871211. It looks like you pushed a fix for the linting issue but nobody was pinged, so that wasn't visible to anyone. Sorry for the delay there. I've approved the new commit and started the merge process, it'll complete automatically in a few minutes. Thanks for the contribution! |
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in d5679f4 |
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this pull request
Jul 1, 2026
Signed-off-by: Yu-Sheng Chen <samuel871211@gmail.com> PR-URL: nodejs#63298 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/nodejs/node/blob/main/lib/internal/http2/core.js#L3505
Related PR: #57586